[13/n] [dropshot_endpoint] support channels in API traits#1038
Merged
sunshowers merged 6 commits intoJul 12, 2024
Merged
Conversation
Created using spr 1.3.6-beta.1 [skip ci]
Created using spr 1.3.6-beta.1
5 tasks
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Contributor
Author
|
@ahl whenever you're back a review on this would be really appreciated. It is mostly tests with ~500 lines of real code. thanks! |
ahl
approved these changes
Jul 12, 2024
ahl
left a comment
Collaborator
There was a problem hiding this comment.
I didn't look at this very closely -- I kind of figure the tests speak for themselves. If there are parts that you think require a more fine-grained review, please let me know
Created using spr 1.3.6-beta.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building on the work in the last few PRs, this is relatively straightforward.
The bulk of the PR is simply tests for bad channels -- we now have mirrored
tests for all four combinations of (macro kind, endpoint kind).