Prepared AsciiDoc document and ESM build#82
Merged
Conversation
benjaminleonard
commented
Nov 12, 2024
| import type { CSSProperties } from 'react' | ||
| import type { Config, TransformedToken } from 'style-dictionary' | ||
| import StyleDictionary from 'style-dictionary' | ||
| import dedent from 'ts-dedent' |
Collaborator
Author
There was a problem hiding this comment.
Removed due to no ESM build
benjaminleonard
commented
Nov 12, 2024
| }, | ||
| }) | ||
|
|
||
| type ColorGroup = { [colorValue: string]: TransformedToken[] } |
Collaborator
Author
There was a problem hiding this comment.
We're not using these right now, I think can reduce some complexity by removing. (Also they don't gel well with regular dedent)
benjaminleonard
commented
Nov 12, 2024
| "purple-accent": "enabled", | ||
| "main": "enabled" | ||
| "main": "enabled", | ||
| "green-accent": "disabled" |
Collaborator
Author
There was a problem hiding this comment.
Might need to resync with the figma tokens plugin. I suspect this change is a mistake.
benjaminleonard
commented
Nov 12, 2024
| entry: ['components/src/index.ts'], | ||
| outDir: 'components/dist', | ||
| external: ['react/jsx-runtime'], | ||
| splitting: false, |
Collaborator
Author
There was a problem hiding this comment.
Supported in ESM and on by default
This was referenced Nov 12, 2024
Closed
Collaborator
|
Works in web console: oxidecomputer/console#2552 |
Collaborator
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP