Allow React 19 in peer deps#118
Merged
Merged
Conversation
david-crespo
commented
Feb 17, 2025
8 tasks
Collaborator
Author
|
I tested the canary on the marketing site, which is on React 18, to make sure it doesn't only work with React 19. It all seemed to work fine. |
david-crespo
commented
Feb 17, 2025
| "@floating-ui/react": "^0.25.1", | ||
| "@headlessui/react": "^1.7.17", | ||
| "@floating-ui/react": "^0.27.4", | ||
| "@headlessui/react": "^2.2.0", |
Collaborator
Author
There was a problem hiding this comment.
This is the only major bump, so it's worth testing specifically. It's used in the Listbox, which is only used in one spot: the marketing site events page. It works fine.
Collaborator
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just changing the peer deps might be insufficient. We might need to bump stuff like
@headlessui/react.