Skip to content

update to latest vergen#1770

Merged
jgallagher merged 2 commits into
mainfrom
john/update-vergen
Sep 17, 2025
Merged

update to latest vergen#1770
jgallagher merged 2 commits into
mainfrom
john/update-vergen

Conversation

@jgallagher

@jgallagher jgallagher commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

I diffed the build script output before and after this change, and all the VERGEN_* env variable output was identical. The exact changes (which seem fine?) were

<   cargo:rustc-env=VERGEN_CARGO_DEPENDENCIES=anyhow 1.0.98,atty 0.2.14,crucible-workspace-hack 0.1.0,dropshot 0.16.2,nix 0.29.0,proptest 1.6.0,rustls-pemfile 1.0.4,schemars 0.8.22,serde 1.0.219,serde_json 1.0.140,slog 2.7.0,slog-async 2.8.0,slog-bunyan 2.5.0,slog-dtrace 0.3.0,slog-term 2.9.1,tempfile 3.19.1,test-strategy 0.4.1,thiserror 2.0.12,tokio 1.45.1,tokio-rustls 0.24.1,toml 0.8.23,twox-hash 2.1.0,uuid 1.16.0,vergen 8.3.2
---
>   cargo:rustc-env=VERGEN_CARGO_DEPENDENCIES=anyhow 1.0.98,atty 0.2.14,crucible-workspace-hack 0.1.0,dropshot 0.16.2,nix 0.29.0,proptest 1.6.0,rustls-pemfile 1.0.4,schemars 0.8.22,serde 1.0.219,serde_json 1.0.140,slog 2.7.0,slog-async 2.8.0,slog-bunyan 2.5.0,slog-dtrace 0.3.0,slog-term 2.9.1,tempfile 3.19.1,test-strategy 0.4.1,thiserror 2.0.12,tokio 1.45.1,tokio-rustls 0.24.1,toml 0.8.23,twox-hash 2.1.0,uuid 1.16.0,vergen 9.0.6,vergen-git2 1.0.7
24c25
<   cargo:rerun-if-changed=/home/john/github/crucible/.git/
---
>   cargo:rerun-if-changed=/home/john/github/crucible/.git/refs/heads/main

@jgallagher jgallagher requested a review from leftwo September 17, 2025 19:07
jgallagher
jgallagher commented Sep 17, 2025
View reviewed changes
Comment thread common/Cargo.toml
[build-dependencies]
vergen = { version = "8.3.2", features = ["cargo", "git", "git2", "rustc" ] }
vergen = { version = "9.0.6", features = ["cargo", "rustc"] }
vergen-git2 = "1.0.7"

@jgallagher jgallagher Sep 17, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could use vergen-gix instead to avoid linking against libgit2 altogether? But that pulled in a lot more Cargo.lock changes, so I just went with the successor to what we had before (vergen 8's git2 feature).

@jgallagher jgallagher mentioned this pull request Sep 17, 2025
Merged
@jgallagher jgallagher merged commit 65ca41e into main Sep 17, 2025
17 checks passed
@jgallagher jgallagher deleted the john/update-vergen branch September 17, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leftwo leftwo leftwo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jgallagher @leftwo