Skip to content

Use the omicron-zone-package methods for topo sorting#1099

Merged
smklein merged 2 commits into
mainfrom
topo-sort-lib
Jan 15, 2024
Merged

Use the omicron-zone-package methods for topo sorting#1099
smklein merged 2 commits into
mainfrom
topo-sort-lib

Conversation

@smklein

@smklein smklein commented Jan 15, 2024

Copy link
Copy Markdown
Contributor

I moved this logic (and tested it) in omicron-zone-package: oxidecomputer/omicron-package#57

This PR uses that version, to simplify how much logic Crucible needs to know

@smklein smklein requested review from karencfv and leftwo January 15, 2024 22:48

@karencfv karencfv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@smklein smklein merged commit e30353d into main Jan 15, 2024
@smklein smklein deleted the topo-sort-lib branch January 15, 2024 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants