Filter out already-attached disks from instance create and edit views#2257
Closed
charliepark wants to merge 3 commits into
Closed
Filter out already-attached disks from instance create and edit views#2257charliepark wants to merge 3 commits into
charliepark wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Collaborator
|
Note you could avoid moving the API call up by passing in the list of attached disks to the side modal and letting it handle removing them from the list. Not sure which is better! |
Contributor
Author
|
Closing, as there's a cleaner implementation in #2262 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not ready for review yet; just saving this as a draft PR so I can write down some notes and come back to it.
Fixes #2254