Select an option or enter a custom value
What we have is decent, but I just want to flag that we should keep mulling it over before v11 in case we come up with something better. It might help to explain somewhere (in this help text or elsewhere) that the match works by string, and therefore it can be any string, even one that doesn't match any instances yet. At least, that's what I want to convey — doesn't mean we have to say it exactly like that.
|
{valueType === 'vpc' || valueType === 'subnet' || valueType === 'instance' ? ( |
|
<ComboboxField |
|
isDisabled={isDisabled} |
|
name="value" |
|
{...getFilterValueProps(valueType)} |
|
description="Select an option or enter a custom value" |
What we have is decent, but I just want to flag that we should keep mulling it over before v11 in case we come up with something better. It might help to explain somewhere (in this help text or elsewhere) that the match works by string, and therefore it can be any string, even one that doesn't match any instances yet. At least, that's what I want to convey — doesn't mean we have to say it exactly like that.
console/app/forms/firewall-rules-common.tsx
Lines 124 to 129 in ce242e7