Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: oxidecomputer/console
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 927c8b63
Choose a base ref
...
head repository: oxidecomputer/console
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: c1ebd8d9
Choose a head ref
  • 18 commits
  • 43 files changed
  • 6 contributors

Commits on Dec 6, 2024

  1. Configuration menu
    Copy the full SHA
    dc5562f View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2024

  1. fix(deps): update dependency @oxide/design-system to v1.7.6 (#2609)

    Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
    renovate[bot] authored Dec 10, 2024
    Configuration menu
    Copy the full SHA
    dbd8545 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d031c8f View commit details
    Browse the repository at this point in the history
  3. Escape should close combobox/listbox inside modal without closing mod…

    …al (#2610)
    
    * fix escape in combobox in dialog: no capture:true in radix esc handler
    
    * try making @radix-ui/react-use-escape-keydown an explicit dep
    
    * actually the problem was the node cache
    david-crespo authored Dec 10, 2024
    Configuration menu
    Copy the full SHA
    0c873cf View commit details
    Browse the repository at this point in the history
  4. npm audit fix

    david-crespo committed Dec 10, 2024
    Configuration menu
    Copy the full SHA
    0b5220a View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2024

  1. Fix e2e flake by not consuming abort signal in apiq query options h…

    …elper (#2614)
    
    don't consume abort signal in apiq query function
    david-crespo authored Dec 11, 2024
    Configuration menu
    Copy the full SHA
    7a8ee0a View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2024

  1. Add view/edit SSH key page (#2589)

    * Add view/edit SSH key page
    
    * Tweak `expectVisible` to take container
    
    * Add copy button
    
    * Add copy in actions menu
    
    * Revert "Tweak `expectVisible` to take container"
    
    This reverts commit c7d3c56.
    
    * Update ssh-keys.e2e.ts
    
    * rename form to "View SSH key"
    
    * don't use stringy locators and expectVisible
    
    * Bot commit: format with prettier
    
    ---------
    
    Co-authored-by: David Crespo <david.crespo@oxidecomputer.com>
    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
    3 people authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    bdbc02b View commit details
    Browse the repository at this point in the history
  2. Fix instance disk menus closing on poll (#2618)

    fix instance disk menus closing on poll
    david-crespo authored Dec 12, 2024
    Configuration menu
    Copy the full SHA
    79d610d View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2024

  1. Configuration menu
    Copy the full SHA
    aaf1154 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9e1d53c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bc3161a View commit details
    Browse the repository at this point in the history
  4. Add read-only UI for internet gateways (#2488)

    * Update OMICRON_VERSION
    
    * update msw handlers
    
    * Other changes from initial branch
    
    * IP Pools tab in place
    
    * IP Pool ID is copyable from IP Pools tab
    
    * Add content to IP Addresses tab and root page
    
    * Update OMICRON_VERSION to sha with internet gateways
    
    * small tweaks
    
    * remove commented-out code
    
    * Use proper truncate component
    
    * adjust path-builder spec
    
    * Add breadcrumb nav for internet gateways
    
    * Update default internet gateway IP pool to reflect actual default values
    
    * update unrelated test
    
    * Remove n+1 query on IpPools
    
    * Add IpPoolCell
    
    * Remove code that we'll add separately
    
    * Upgrade OMICRON_VERSION
    
    * No need to extract UtilizationCell now
    
    * Get IP Pool tab for Internet Gateways working
    
    * Update snapshot, but there might still be some other issues to work out
    
    * Some headway, but screen is still blank
    
    * Update snapshots for test
    
    * Update routes; fix mock data
    
    * update tests with mock data, but this should probably get pulled to a new branch
    
    * Simplify mock data; renaming the default IP Pool to default was unnecessary and confusing
    
    * convert to new useQueryTable
    
    * Add internet gateway combobox to router route target field
    
    * Sidebar for Internet Gateway coming together
    
    * Bot commit: format with prettier
    
    * DOM shuffling
    
    * Update mock data
    
    * Update routes to handle new sidebar and main tab together
    
    * Reorder internet gateway sidebar
    
    * Update paths and snapshots
    
    * use more common internet-gateway-edit syntax for filename
    
    * Internet gateways modal tweak (#2607)
    
    Internet gateway modal tweaks
    
    * Add IP Address and IP Pool columns to Gateway table
    
    * test update
    
    * small tweaks to sidebar
    
    * reverting back to vertical table for now, to render IP Pool alonside join table info
    
    * Update copy when missing pool or ip address
    
    * Add a test for internet gateway list and sidemodal
    
    * Add routes targeting gateway to table
    
    * Better handle multiple route spacing; fix test
    
    * Update side modal with routes targeting gateway
    
    * Update test for showing route
    
    * Tweaks to sidemodal
    
    * move example gateway route to custom router, not default router
    
    * Update tests to reflect gateway route existing on custom router
    
    * use more specific params in queries
    
    * use titleCrumb for Edit Internet Gateway
    
    * fix RR leaf route without element warning
    
    * let's use a valid UUID
    
    * clean up InternetGatewayRoutes and call it as a component
    
    * update the snapshot!
    
    * fix gnarly dependent promises in gateways loader
    
    * update read only info box
    
    * clean up gateway routes fetch logic by extracting shared hook
    
    * extract gateway data logic into a separate file
    
    * Use count of routes; link to sidemodal
    
    * Use count of 0 instead of EmptyCell for route count
    
    * use EmptyCell for zero routes, copy tweaks, sentence case
    
    * sentence case idp form heading
    
    * minor: remove stub e2e test
    
    ---------
    
    Co-authored-by: David Crespo <david.crespo@oxidecomputer.com>
    Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
    Co-authored-by: Benjamin Leonard <benji@oxide.computer>
    4 people authored Dec 13, 2024
    Configuration menu
    Copy the full SHA
    ada302c View commit details
    Browse the repository at this point in the history
  5. Add switches tab to system inventory (#2620)

    * Add switches tab
    
    * Add basic test
    
    * Update path snapshots
    
    * Drop Rack ID for now
    
    * womp womp test update
    charliepark authored Dec 13, 2024
    Configuration menu
    Copy the full SHA
    11486f8 View commit details
    Browse the repository at this point in the history
  6. Add confirmation modal for disk detachment (#2615)

    * Add confirmation modal for disk detachment
    
    * add in a few confirmation clicks in tests
    
    * danger, will robinson
    
    * save 4 lines
    
    ---------
    
    Co-authored-by: David Crespo <david.crespo@oxidecomputer.com>
    charliepark and david-crespo authored Dec 13, 2024
    Configuration menu
    Copy the full SHA
    1dd25f6 View commit details
    Browse the repository at this point in the history
  7. Gateway route links to router instead of route edit form (#2622)

    gateway route links to router instead of route edit form
    david-crespo authored Dec 13, 2024
    Configuration menu
    Copy the full SHA
    c1fbf63 View commit details
    Browse the repository at this point in the history
  8. Remove footer when side modal is read-only (#2621)

    * Remove sidemodal footer when read-only
    
    * Update test to use X to close modal
    
    * move close button back into SideModal
    
    ---------
    
    Co-authored-by: David Crespo <david.crespo@oxidecomputer.com>
    charliepark and david-crespo authored Dec 13, 2024
    Configuration menu
    Copy the full SHA
    2b0c3f1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    2a13902 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    c1ebd8d View commit details
    Browse the repository at this point in the history
Loading