inline getUseApiQueryClient

…elsewhere

…itions (#2566)

refactor useApiQuery hooks to use queryOptions helper internally

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

#2567)

* redo useQueryTable so that the types are legit and it returns the data

* fix junky getRowId and use new QueryTable on sleds and physical disks

* get wild with a list-specific helper to make the call sites clean

* encapsulate pageSize in the query config so it is defined in one place

* do the placeholderData thing for all lists

* scroll to top when page changes

* loading spinner on page changes!

* fix the pagination test, test lovely new scroll reset logic

* fix other e2es, don't scroll reset on browser forward/back

* fix bug found while converting other tables, extract useScrollReset

* redo useQueryTable so that the types are legit and it returns the data

* fix junky getRowId and use new QueryTable on sleds and physical disks

* get wild with a list-specific helper to make the call sites clean

* encapsulate pageSize in the query config so it is defined in one place

* do the placeholderData thing for all lists

* scroll to top when page changes

* loading spinner on page changes!

* fix the pagination test, test lovely new scroll reset logic

* fix other e2es, don't scroll reset on browser forward/back

* fix bug found while converting other tables, extract useScrollReset

* move columns up

* convert instance list to new QueryTable, fix polling bug

* redo useQueryTable so that the types are legit and it returns the data

* fix junky getRowId and use new QueryTable on sleds and physical disks

* get wild with a list-specific helper to make the call sites clean

* encapsulate pageSize in the query config so it is defined in one place

* do the placeholderData thing for all lists

* scroll to top when page changes

* loading spinner on page changes!

* fix the pagination test, test lovely new scroll reset logic

* fix other e2es, don't scroll reset on browser forward/back

* fix bug found while converting other tables, extract useScrollReset

* move columns up

* convert instance list to new QueryTable, fix polling bug

* convert the rest of the tables

* convert a few more

* a hard one: IpPoolPage, have to handle rows with no ID field

* last few easy ones

* last ones and delete QueryTable

* rename file back to QueryTable

cut a few lines by cleaning up types and shuffling things

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Co-authored-by: Benjamin Leonard <benji@oxide.computer>
Co-authored-by: Charlie Park <charlie@oxidecomputer.com>
Co-authored-by: Benjamin Leonard <hello@benleonard.co.uk>