fix: stabilize flaky TestSyncClientImpl_InternalKeys#939
Merged
Conversation
663a2a0 to
ff8db39
Compare
The test used `assert.NotEmpty` to check for remaining items after consuming 4 RangeScan results with ShowInternalKeys(true). This was flaky because system-created internal keys (__oxia/commit-offset, __oxia/term, etc.) arrive asynchronously via a buffered channel. Replace with collecting remaining items and verifying they have the `__oxia/` internal key prefix. Closes #936 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: mattisonchao <mattisonchao@gmail.com>
8b7641b to
eda78b8
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: mattisonchao <mattisonchao@gmail.com>
merlimat
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestSyncClientImpl_InternalKeysthat failed intermittently on CIassert.NotEmptywithassert.Eventuallyto check for remaining RangeScan results after consuming 4 items withShowInternalKeys(true)__oxia/commit-offset,__oxia/term, etc.) arrive asynchronously via a buffered channel, makingassert.NotEmptytiming-dependentfor range resChCloses #936
Test plan
-race -count=20