fix: stabilize flaky TestLeaderHint tests#916
Merged
mattisonchao merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
…utClient Wait for ShardStatusSteadyState with a leader present instead of just leader election before performing operations. The previous check (shard.Leader != nil with 1s timeout) was insufficient — followers may not have received shard assignments yet, causing EOF and "node is not leader" errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ab83cb3 to
0608213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TestLeaderHintWithClientandTestLeaderHintWithoutClientthat intermittently fail with EOF / "node is not leader" errorsshard.Leader != nil(with a 1s timeout), which is insufficient — the cluster may still be in election state with followers not yet having received shard assignments via the dispatcherShardStatusSteadyState(with a 10s timeout) before performing operations, matching the established pattern used across all other integration testsTest plan
go vet ./tests/assignments/...passes🤖 Generated with Claude Code