fix: dynamic log level changes now affect existing loggers#914
Merged
mattisonchao merged 1 commit intomainfrom Feb 26, 2026
Merged
fix: dynamic log level changes now affect existing loggers#914mattisonchao merged 1 commit intomainfrom
mattisonchao merged 1 commit intomainfrom
Conversation
Previously, ReconfigureLogger() recreated the entire handler and called slog.SetDefault(), but component loggers created earlier via slog.With() still referenced the old handler with the old level. By using a shared slog.LevelVar (atomic) passed to the handler, all existing loggers pick up level changes immediately without handler recreation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
slog.LevelVar(atomic) instead of a concreteslog.Levelwhen configuring the slog-zerolog handler, so all loggers (including derived ones fromslog.With()) dynamically pick up level changesReconfigureLogger()to atomically update the shared level variable instead of recreating the entire handlerTest plan
go test ./oxiad/common/logging/...— new tests passgo test ./oxiad/dataserver/...— all passgo test ./oxiad/coordinator/...— all passgo test ./cmd/server/...— passes