Review Summary

Comprehensive review of the diff against main — no bugs or regressions found.

What changed

• leaderController.term changed from int64 to *atomic.Int64
• setLogger() removed — logger is created once in the constructor and never reassigned, eliminating the data race on lc.log
• Term() getter is now lock-free (lc.term.Load())
• All lc.log local captures (log := lc.log) reverted since lc.log is immutable after construction
• term attribute added to all log call sites explicitly (was previously baked into the base logger via setLogger())
• Methods with multiple lc.term.Load() calls extract a local variable to avoid redundant atomic loads
• Bonus: fixed a wrong log message in RangeScan ("Received list request" → "Received range-scan request")

Verified

• All lc.term reads use .Load(), all writes use .Store() — no bare field access remaining
• Methods that held the write lock when modifying term still do (NewTerm, constructor)
• Local term captures in becomeLeader, addFollower, truncateFollowerIfNeeded, applyAllEntriesIntoDB, DeleteShard are all under lock, so they see a consistent value
• Async callbacks in proposeFeaturesEnable and ProposeRecordChecksum capture term at call time (not callback time) to log the term under which the proposal was made
• session_manager.go uses controller.term.Load() — eagerly resolved by slog.With, same behavior as the original int64 field

Known limitation

• slog.With() eagerly resolves values, so term cannot be dynamically included in the base logger without a custom slog.Handler. Instead, term is passed explicitly at each log call site.