Merged
Conversation
Thread the chained CRC computed at the WAL codec level through the read path (codec → segment → WAL → reader → controllers) and expose it as a Prometheus gauge metric `oxia_dataserver_wal_checksum`, complementing the existing `oxia_dataserver_db_checksum`. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Member
Author
ReviewLGTM. Reviewed the full diff against main (21 files, +154/-109). What's good
Notes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Add the
oxia_dataserver_wal_checksummetric specified in Discussion #849 to complement the existingoxia_dataserver_db_checksumfor shard consistency validation. The WAL already computes chained CRC values at the codec level but never exposes them.Modification
ReadRecordWithValidation(codec) →Read(segment) →readAtIndex(WAL) →ReadNext(reader) → controllersAppendAndSynccallback to carry the entry CRC, capturingLastCrc()after append under the WAL lockwalChecksumGaugeto both leader and follower controllers, recording the WAL CRC alongside the existing DB checksum gaugeoxia_dataserver_wal_checksumappears with correct attributes and non-zero values🤖 Generated with Claude Code