fixes the wrong cluster config parameter name#864
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses a breaking change introduced in #859 by restoring backward compatibility for the cluster configuration parameter and introducing separate flags for server and cluster configuration.
Changes:
- Renamed server config variable from
confFiletosconfFileand introduced--sconfigflag - Maintained
--confflag for cluster configuration with deprecation notice, and added new--cconfigflag - Updated test code to use the new
sconfFilevariable name
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| cmd/server/cmd.go | Renamed confFile variable to sconfFile and changed flag from --conf to --sconfig for server configuration |
| cmd/server/cmd_test.go | Updated test to reference renamed sconfFile variable |
| cmd/coordinator/cmd.go | Added --sconfig for server config, maintained deprecated --conf with -f short flag, and added --cconfig for cluster config |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Motivation
#859 introduced the server-side configuration, but it is breaking the existing cluster configuration parameter name.
Modification
confparameter.--sconfigas server configuration path parameter.--cconfigas cluster configuration path parameter.confparameter and use the new--cconfiginstead.