Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the WAL sync configuration option introduced in #367 was not being used. The hardcoded SyncData: true value has been replaced with a call to storage.WAL.IsSyncEnabled() to respect the user's configuration.
Changes:
- Updated
NewWithGrpcProviderto use the configurableIsSyncEnabled()method instead of hardcodedtruefor the WAL sync setting
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
#367 introduced the option to disable WAL, but it didn't take effect for the dataserver.