Skip to content

fix: Resolve CI linter failures (goconst, prealloc, revive)#854

Merged
mattisonchao merged 4 commits intointroduce.configfrom
copilot/sub-pr-848
Jan 14, 2026
Merged

fix: Resolve CI linter failures (goconst, prealloc, revive)#854
mattisonchao merged 4 commits intointroduce.configfrom
copilot/sub-pr-848

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 14, 2026

Fixed CI linter failures blocking the configuration refactoring PR.

Changes

  • goconst: Introduced constant.LocalhostAnyPort to deduplicate 27 instances of "localhost:0" across 11 files
  • prealloc: Added capacity hints to slice allocations in meters.go, async_client_impl_test.go, set.go, and coordinator_e2e_test.go
  • revive: Excluded common/{hash,io,time} packages from var-naming checks to suppress false positives on intentional standard library name reuse
// Before: scattered literals
server := NewServer("localhost:0")
client := Dial("localhost:0")

// After: centralized constant
server := NewServer(constant.LocalhostAnyPort)
client := Dial(constant.LocalhostAnyPort)

All linters now pass with 0 issues.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits January 14, 2026 07:19
Co-authored-by: mattisonchao <74767115+mattisonchao@users.noreply.github.com>
Co-authored-by: mattisonchao <74767115+mattisonchao@users.noreply.github.com>
…tibility

Co-authored-by: mattisonchao <74767115+mattisonchao@users.noreply.github.com>
Copilot AI changed the title [WIP] Establish foundational configuration for DataServer and Coordinator fix: Resolve CI linter failures (goconst, prealloc, revive) Jan 14, 2026
Copilot AI requested a review from mattisonchao January 14, 2026 07:37
@mattisonchao mattisonchao marked this pull request as ready for review January 14, 2026 07:43
@mattisonchao mattisonchao merged commit c3681e8 into introduce.config Jan 14, 2026
1 check passed
@mattisonchao mattisonchao deleted the copilot/sub-pr-848 branch January 14, 2026 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants