Add test coverage for database conversion crash recovery scenarios#839
Closed
Copilot wants to merge 1 commit intofixes.datalost.conversionfrom
Closed
Add test coverage for database conversion crash recovery scenarios#839Copilot wants to merge 1 commit intofixes.datalost.conversionfrom
Copilot wants to merge 1 commit intofixes.datalost.conversionfrom
Conversation
Copilot
AI
changed the title
[WIP] Add test for convertCrashAfterMoveOldDb case
Add test coverage for database conversion crash recovery scenarios
Dec 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses review feedback on #838 requesting test coverage for crash scenarios during database format conversion.
Test Coverage Added
Two tests validate crash recovery during DB format conversion (natural → hierarchical):
TestPebbleDbConversionPreservesDataAfterCrash: Crash after moving old DB to backup but before moving new DB into placekv_pebble_formats.goTestPebbleDbCleanupExpiredBackup: Crash after moving new DB into place but before deleting backupkv_pebble_formats.goBoth tests use the trap mechanism to inject failures at specific points in the conversion flow, then verify recovery behavior on retry.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.