Allow to configure key-sorting natural/hierarchical on namespaces#818
Merged
mattisonchao merged 6 commits intooxia-db:mainfrom Nov 22, 2025
Merged
Allow to configure key-sorting natural/hierarchical on namespaces#818mattisonchao merged 6 commits intooxia-db:mainfrom
mattisonchao merged 6 commits intooxia-db:mainfrom
Conversation
Signed-off-by: Matteo Merli <mmerli@apache.org>
Signed-off-by: Matteo Merli <mmerli@apache.org>
Signed-off-by: Matteo Merli <mmerli@apache.org>
Signed-off-by: Matteo Merli <mmerli@apache.org>
| &proto.NewTermOptions{EnableNotifications: enableNotification.Get()}, | ||
| &proto.NewTermOptions{ | ||
| EnableNotifications: enableNotification.Get(), | ||
| KeySorting: nsConfig.KeySorting.ToProto(), |
| InitialShardCount uint32 `json:"initialShardCount" yaml:"initialShardCount"` | ||
| ReplicationFactor uint32 `json:"replicationFactor" yaml:"replicationFactor"` | ||
| NotificationsEnabled entity.OptBooleanDefaultTrue `json:"notificationsEnabled" yaml:"notificationsEnabled"` | ||
| KeySorting KeySorting `json:"keySorting" yaml:"keySorting"` |
Member
There was a problem hiding this comment.
It's better to add json:"keySorting" yaml:"keySorting,omitempty".
| } | ||
| } | ||
|
|
||
| func KeySortingFromProto(s proto.KeySortingType) KeySorting { |
Member
There was a problem hiding this comment.
Hmm... it seems this method is mainly used for testing. In my opinion, we should use plain text for testing to simulate real-world usage.
mattisonchao
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ability to select key sorting on namespaces.
By default, we will continue to use the "hierarchical" sorting. At some point, the default might get switched.