refactor: introduce thread safe shard metadata#791
Merged
mattisonchao merged 11 commits intomainfrom Oct 25, 2025
Merged
Conversation
Member
Author
|
rely on #788 |
5c1787c to
35b0ea7
Compare
Signed-off-by: mattisonchao <mattisonchao@gmail.com>
Signed-off-by: mattisonchao <mattisonchao@gmail.com>
Signed-off-by: mattisonchao <mattisonchao@gmail.com>
merlimat
approved these changes
Oct 25, 2025
| DefaultPeriodicTasksInterval = 1 * time.Minute | ||
| ) | ||
|
|
||
| // --------------------------- Metadata ----------------------------- |
Collaborator
There was a problem hiding this comment.
Maybe move to a separate file? Also, maybe use an interface
Member
Author
There was a problem hiding this comment.
moved to a separate file.
Also, maybe use an interface
It's only the shard controller memory metadata. We don't need to give it an interface so far. We could add it when we really need it. :)
Signed-off-by: mattisonchao <mattisonchao@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR introduces a thread-safe metadata structure to hide the locks behind operations. It also changes the way election pipeline metadata is accessed to use mutable clone metadata to avoid touching the metadata structure with a lock.