fix(session): avoid complete rpc without response#744
Merged
Conversation
merlimat
reviewed
Aug 28, 2025
| } | ||
|
|
||
| s.log.Warn("Session not found, it should already closed") | ||
| return nil, err |
Collaborator
There was a problem hiding this comment.
This is going to propagate the SessionNotFound back to client, right?
Member
Author
There was a problem hiding this comment.
Yes, I was considering hiding it. But on the server-side, we should give a clear error to the client and then let the client decide what they should do. :)
Member
Author
There was a problem hiding this comment.
Plus, we propagated the error to the client at the beginning of the system.
#609 changed the behaviour. (I accept we don't print the warn log on the server, but we shouldn't hide anything )
merlimat
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fixes: #745
The current logic will return
nil,nilto the client when the session is not found. which is confusing the client side because we didn't give the correct response body, but an OK status.