feat: introduce committed version IDs to avoid accidentally writing dirty version ID trackers#740
Merged
mattisonchao merged 5 commits intomainfrom Aug 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces committed version IDs to prevent accidental writes of dirty version ID trackers by separating in-memory tracking from committed state.
- Renames
versionIdTrackertocommittedVersionIDTrackerto clarify it tracks only committed versions - Adds local version ID tracking during write operations to avoid prematurely updating the committed tracker
- Updates the committed tracker only after successful batch commits
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
RobertIndie
approved these changes
Aug 27, 2025
2b43aa7 to
a131429
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
introduce committed version IDs to avoid accidentally writing dirty version ID trackers
Modification