Skip to content

Always validate shard id not to be null#736

Merged
mattisonchao merged 1 commit intooxia-db:mainfrom
merlimat:fix-npe
Jul 20, 2025
Merged

Always validate shard id not to be null#736
mattisonchao merged 1 commit intooxia-db:mainfrom
merlimat:fix-npe

Conversation

@merlimat
Copy link
Copy Markdown
Collaborator

@merlimat merlimat commented Jul 18, 2025

Fixes:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x10455fcd0]

goroutine 83 [running]:
github.com/oxia-db/oxia/server.(*publicRpcServer).Write(0x1400031b040, {0x1050bfda8, 0x140005936e0}, 0x1400057c700)
	/Users/mmerli/prg/oxia/server/public_rpc_server.go:105 +0x120
github.com/oxia-db/oxia/proto._OxiaClient_Write_Handler.func1({0x1050bfda8?, 0x140005936e0?}, {0x104fcd0c0?, 0x1400057c700?})
	/Users/mmerli/prg/oxia/proto/client_grpc.pb.go:491 +0xd0
github.com/grpc-ecosystem/go-grpc-prometheus.init.(*ServerMetrics).UnaryServerInterceptor.func3({0x1050bfda8, 0x140005936e0}, {0x104fcd0c0, 0x1400057c700}, 0x80?, 0x14000513578)
	/Users/mmerli/go/pkg/mod/github.com/grpc-ecosystem/go-grpc-prometheus@v1.2.0/server_metrics.go:107 +0x6c
github.com/oxia-db/oxia/proto._OxiaClient_Write_Handler({0x104f329c0, 0x1400031b040}, {0x1050bfda8, 0x140005936e0}, 0x1400057c680, 0x1400035d170)
	/Users/mmerli/prg/oxia/proto/client_grpc.pb.go:493 +0x148
google.golang.org/grpc.(*Server).processUnaryRPC(0x14000252200, {0x1050bfda8, 0x14000593650}, 0x14000499320, 0x140004752f0, 0x1064567a0, 0x0)
	/Users/mmerli/go/pkg/mod/google.golang.org/grpc@v1.72.0/server.go:1405 +0xc9c
google.golang.org/grpc.(*Server).handleStream(0x14000252200, {0x1050c1270, 0x1400011e000}, 0x14000499320)
	/Users/mmerli/go/pkg/mod/google.golang.org/grpc@v1.72.0/server.go:1815 +0x900
google.golang.org/grpc.(*Server).serveStreams.func2.1()
	/Users/mmerli/go/pkg/mod/google.golang.org/grpc@v1.72.0/server.go:1035 +0x84
created by google.golang.org/grpc.(*Server).serveStreams.func2 in goroutine 82
	/Users/mmerli/go/pkg/mod/google.golang.org/grpc@v1.72.0/server.go:1046 +0x138

@mattisonchao mattisonchao merged commit f32868d into oxia-db:main Jul 20, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants