Static check for noalloc: even nicer error messages#864
Closed
gretay-js wants to merge 3 commits intooxcaml:mainfrom
Closed
Static check for noalloc: even nicer error messages#864gretay-js wants to merge 3 commits intooxcaml:mainfrom
gretay-js wants to merge 3 commits intooxcaml:mainfrom
Conversation
Contributor
|
Can we close this one since #1157 has been opened ? |
Contributor
Author
|
superseded by #1157 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improves the error messages introduced in #826 to point to the annotation (instead of highlighting the entire function's body). I tested it in the editor on a bunch of large functions and I think it is more convenient.
Unfortunately, to do it we need to keep track of the location of the attribute all the way through the middle-end. It's not a big code change, because the
Debuginfo.tpropagated alongside thepropertydoesn't need to be updated.