Remove nolabels attribute from unixLabels#751
Closed
mshinwell wants to merge 1 commit intooxcaml:mainfrom
Closed
Conversation
Collaborator
Author
Collaborator
Author
|
This fix was merged in the internal assembler PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to remove the
nolabelsattribute fromunixLabels.mlso that theunixlibrary can be used in the boot compiler. We'd like this so thatoweecan be linked into the boot compiler, in turn enabling direct writing of.ofiles bypassing the system assembler (by using the binary emitter).We'll probably have to merge this and test on the JS tree to see if it works ok. One problem is that
unix.cmxswill no longer containUnixLabelsbut I'm hoping we can get away with that.In due course if dune starts supporting per-file compilation flags, this could all be simplified.