Fix duplicate lifted constants for code of lifted sets of closures#567
Merged
mshinwell merged 7 commits intooxcaml:mainfrom Jun 15, 2022
Merged
Conversation
Contributor
Author
|
This PR now also contains a relatively big refactoring around the propagation of accumulators, to fix the handling of groups of mutually recursive lifted sets of closures (the |
Contributor
Author
|
Note: the bugs fixed by this PR cannot be triggered currently, as they only occur when |
Fixes simplification of groups of lifted sets of closures
21a04ab to
3b00f90
Compare
mshinwell
approved these changes
Jun 15, 2022
chambart
approved these changes
Jun 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while working on #164. The code generated by simplifying a lifted set of closures is already added to the lifted constants of the accumulator in the shared
simplify_set_of_closures0function, so returning it as a new binding insimplify_lifted_set_of_closures0creates a duplicate binding. If the code and the closure are mutually recursive, this should be handled by the normal mechanism inLifted_constant_state.