Annotate Cmm.fundecl with only_kept_for_zero_alloc#2813
Draft
mshinwell wants to merge 1 commit intooxcaml:mainfrom
Draft
Annotate Cmm.fundecl with only_kept_for_zero_alloc#2813mshinwell wants to merge 1 commit intooxcaml:mainfrom
mshinwell wants to merge 1 commit intooxcaml:mainfrom
Conversation
Collaborator
Author
|
Small example: |
Collaborator
Author
|
(If we want to go ahead with something like this, @Gbury should look at the dataflow-related part of this PR to make sure it matches the specification above.) |
Contributor
|
As said some time ago on slack: the current code seems okay (for the data flow part at least), but it's not great to run the whole data_flow analysis twice. Instead I'd prefer if only the reachability analysis part of the flow analysis was run twice. |
Collaborator
Author
|
@gretay-js what should we do with this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It should be the case that the flag is set iff:
Checkattribute; andWIP for @gretay-js