Conversation
Contributor
Author
|
There is one thing that might feel a bit awkward @gretay-js do you think it is OK, or should we |
Collaborator
|
@gretay-js please review. I'm ok with the proposed approach. |
gretay-js
approved these changes
Jul 16, 2024
Contributor
gretay-js
left a comment
There was a problem hiding this comment.
I think we should remove Compiler_pass.Scheduling from Clflags, and update tools that refer to it (such as build rules for and ir viewers). This is also used in -stop-after and -save-ir compiler flags, so it may need updating existing tests and testing. It can be done as a follow up. We should also remove -dschedul flag.
f0dd291 to
8e2137d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the backends we support currently
define scheduling as the identity, we can
delete the modules without any change
in terms of performance.