Fix frame pointers build under runtime5#2602
Closed
mshinwell wants to merge 3 commits intooxcaml:mainfrom
Closed
Conversation
xclerc
approved these changes
May 21, 2024
(cherry picked from commit 4184a7150d754a7d4903566ed5851e2d8f56e8a9)
Collaborator
Author
|
We'll merge this as part of #2603 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Under runtime5 there is an unused function
rewrite_frame_pointerswhich the C compiler complains about, unless stack checks are enabled. This PR fixes that and changes one of the existing CI jobs to use runtime5 and frame pointers.@xclerc please review