Closed
Conversation
xclerc
reviewed
Apr 25, 2024
Contributor
|
(If it is not too cumbersome, a couple |
xclerc
approved these changes
Apr 26, 2024
... for the lack of a better name
413cf45 to
f1846d5
Compare
Contributor
Author
|
Included in #2524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #2489. Only the last 2 commits are new.
Symbolic summaries in "dnf-like" normal form can sometimes explode. To avoid it, this PR abstract join of more than
nelements to Top. The first commit adds a temporary compilation flag-checkmach-jointo controln. The second commit actual implements this widening and is currently a bit of a hack to bail out early in the middle ofdistribute_transform_over_joinand other operations that increase the number of elements in a join.