Zero alloc: fix join of Transform with the same variables#2487
Closed
gretay-js wants to merge 23 commits intooxcaml:mainfrom
Closed
Zero alloc: fix join of Transform with the same variables#2487gretay-js wants to merge 23 commits intooxcaml:mainfrom
gretay-js wants to merge 23 commits intooxcaml:mainfrom
Conversation
xclerc
reviewed
Apr 25, 2024
xclerc
approved these changes
Apr 26, 2024
... for the lack of a better name
391dd47 to
74003ca
Compare
Contributor
Author
|
Included in #2524 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On top of #2428. Only the last commit is new.
This is a bug fix, as @xclerc noted in review of #2428: Join of two
Transform.twith the same variables but different witnesses should result in one Transform with joined witnesses. The fix is to change the representation ofJoin: instead of a set ofTransform.t, use a map from a set of variables toTransform.t.Current implementation is naive because it effectively keeps two sets of variables for each
Transform.t: one as a key in the map and the other as part of the representation ofTransform.t.