Merged
Conversation
96b00c8 to
ade033a
Compare
xclerc
approved these changes
Apr 18, 2024
Contributor
xclerc
left a comment
There was a problem hiding this comment.
I am low confidence, but did not spot any
issues.
(Not right now, but when there are arm64
runner for the CI, I think we should consider
having a job testing arm64 with the debug
runtime.)
…k_check interface
(cherry picked from commit 10f046c)
d9f9b92 to
739f91d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This starts with #2442, #2443 and #2446. The remaining
BACKPORTmarkers (except for one about DLS which will be dealt with in a separate PR) are removed from the arm64 emitter. I've then attempted to enable stack checks by wiring in the newStack_checkinfrastructure.