(low priority) Mode crossing in uniqueness analysis#2377
Draft
riaqn wants to merge 1 commit intooxcaml:mainfrom
Draft
(low priority) Mode crossing in uniqueness analysis#2377riaqn wants to merge 1 commit intooxcaml:mainfrom
riaqn wants to merge 1 commit intooxcaml:mainfrom
Conversation
25db507 to
9de8a25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to add mode crossing to uniqueness analysis.
(won't be working on this for a while; so create a PR as a reminder)
Consider the example:
UA would sequence the usage
u0ofr.xand the usageu1ofr, which will force both to beshared, many.rnode, we will sequenceemptywithu1 = maybe_unique _, which is fine. On ther.xnode, we will sequenceu0 = maybe_unique _withmaybe_unique _, where the second one is inherited fromu1.Note that the
unique_useinu0would be mode-crossed and not affected by the forcing. Theunique_useinu1cannot cross-modes and will trigger error.The solution (unfinished yet in this PR) is to attach the uniqueness/linearity upper bounds to each
Borrowed/Maybe_shared/Shared/Maybe_uniqueusage, and when weseqorpartwo usages, we will take the meet of the upper bounds in those two usages, and use that to mode cross bothunique_use.UsageTree.seq, the upper bounds of parent node should not propagate to child node.texp_typewhich can be checked. Is this too expensive?