Making the testsuite pass with runtime5 by mshinwell · Pull Request #2034 · oxcaml/oxcaml

mshinwell · 2023-11-15T18:07:03Z

This includes and is a continuation of #2027

TheNumbat · 2023-11-15T18:54:46Z

May need to rebase/squash now to get a proper diff from #2027

…uild with runtime4 yet)

…_stack

… as it hangs

…rray_create_local

…read.ml as per systhreads4/

…im.c

…ers/ tests

…j/ tests

…the way, as it hangs" This reverts commit 3319deb.

(cherry picked from commit 5fd93fe)

mshinwell · 2023-11-16T17:00:11Z

Current failing tests with --enable-runtime5 are the following, plus the tool-debugger ones that are temporarily disabled (they seem to cause intermittent hangs):

List of failed tests:
    tests/lib-dynlink-native/'main.ml' with 1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.2.2.1.1.1.1.1.1.1.1.1.1 (run) 
    tests/backtrace/'names.ml' with 2 (bytecode) 
    tests/tool-toplevel/'any.ml' with 1 (toplevel.opt) 
    tests/backtrace/'backtrace_c_exn.ml' with 2 (native) 
    tests/backtrace/'names.ml' with 1 (native) 
    tests/lib-dynlink-private/'test.ml' with 1.2.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1 (run) 
    tests/backtrace/'lazy.ml' with 2.1 (native) 
    tests/instrumented-runtime/'main.ml' with 1.1 (native) Fatal error
    tests/lib-dynlink-pr9209/'dyn.ml' with 1.1.1.1.1.1.1 (run) Process 58826 got signal 11(Segmentation fault
    tests/lib-dynlink-bytecode/'main.ml' with 1.1.1.1.1.1.1.1.1 (run) Process 58158 got signal 11(Segmentation fault
    tests/backtrace/'backtrace_dynlink.ml' with 1.1.1.3.1.1 (check-program-output)

plus the following which are because of missing forward ports from 4.x:

    tests/async-exns/'async_exns_1.ml' with 1 (native) 
    tests/async-exns/'async_exns_1.ml' with 2 (bytecode) 
    tests/tool-ocaml/'t360-stacks-2.ml' with 1.1 (ocaml)   (this uses async exns)
    tests/lib-obj/'get_header.ml' with 2 (bytecode) 
    tests/lib-systhreads/'swapgil.ml' with 1.1.1 (native)

mshinwell · 2023-11-16T17:31:13Z

Updated first list from above:

    tests/lib-dynlink-native/'main.ml' with 1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.2.2.1.1.1.1.1.1.1.1.1.1 (run) 
    tests/tool-toplevel/'any.ml' with 1 (toplevel.opt) 
    tests/lib-dynlink-private/'test.ml' with 1.2.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1 (run) 
    tests/lib-dynlink-bytecode/'main.ml' with 1.1.1.1.1.1.1.1.1 (run) Process 93932 got signal 11(Segmentation fault
    tests/lib-dynlink-pr9209/'dyn.ml' with 1.1.1.1.1.1.1 (run) Process 94677 got signal 11(Segmentation fault
    tests/instrumented-runtime/'main.ml' with 1.1 (native) Fatal error
    tests/backtrace/'backtrace_dynlink.ml' with 1.1.1.3.1.1 (check-program-output)

mshinwell · 2023-11-16T17:58:44Z

Updated status:

    tests/lib-dynlink-native/'main.ml' with 1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.2.2.1.1.1.1.1.1.1.1.1.1 (run)
    tests/lib-dynlink-private/'test.ml' with 1.2.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1.1 (run)
    tests/backtrace/'backtrace_dynlink.ml' with 1.1.1.3.1.1 (check-program-output)

This reverts commit 72538a4.

mshinwell · 2023-11-16T19:23:16Z

The only failures are now the following, which are expected.

List of failed tests:
    tests/async-exns/'async_exns_1.ml' with 1 (native) 
    tests/lib-systhreads/'swapgil.ml' with 1.1.1 (native) 
    tests/async-exns/'async_exns_1.ml' with 2 (bytecode) 
    tests/lib-obj/'get_header.ml' with 2 (bytecode) 
    tests/tool-ocaml/'t360-stacks-2.ml' with 1.1 (ocaml)

…cal/regions.ml test header

mshinwell · 2023-11-17T14:35:21Z

Moved to the runtime5-features branch on ocaml-flambda.

mshinwell added runtime OCaml 5 labels Nov 15, 2023

TheNumbat mentioned this pull request Nov 15, 2023

Runtime 5 forward & backward porting #2027

Merged

TheNumbat changed the base branch from main to runtime5-features November 15, 2023 18:53

mshinwell force-pushed the runtime5-features branch 2 times, most recently from 32d1909 to 8c28baa Compare November 16, 2023 09:26

mshinwell added 7 commits November 16, 2023 09:30

Run max_arity_locals test only when stack allcation is enabled

f9d1dda

Forward port all SIMD runtime changes from d3c1413

93021b3

Actually build systhreads/

837c4d0

Add Condition, Mutex and Semaphore to the stdlib (will probably not b…

e868c43

…uild with runtime4 yet)

Add dummy implementations for caml_local_stack_offset and caml_obj_is…

92f6614

…_stack

Temporarily move ocaml/testsuite/tests/tool-debugger/ out of the way,…

3319deb

… as it hangs

Add dummy implementations for caml_create_local_bytes and caml_floata…

f7af487

…rray_create_local

mshinwell force-pushed the runtime5-features branch from 8c28baa to f7af487 Compare November 16, 2023 09:30

mshinwell added 14 commits November 16, 2023 09:35

Add line directive and -O3 attribute to ocaml/otherlibs/systhreads/th…

5232ffe

…read.ml as per systhreads4/

Promote tests

ec69f2b

More temporary implementations for local-related functions

72981d4

Conditional compilation in ocaml/testsuite/tests/gc-roots/globrootspr…

21639fc

…im.c

Promote tests

1f077e2

Prepare otherlibs/dynlink/ properly for 5

5de64d2

Fix asmgen tests

e3042f4

Dummy C stub for locals again

71c453e

Predicate some tests on having stack allocation

8176e52

Fix and promote typing-local/ tests for stack allocation being disabled

09c17fa

Add runtime4 predicate to ocamltest and use it in runtime-naked-point…

afd1433

…ers/ tests

Fix globrootsprim.c test

e887e13

Add runtime_dir ocamltest variable + use it to fix output-complete-ob…

4b1053f

…j/ tests

Revert "Temporarily move ocaml/testsuite/tests/tool-debugger/ out of …

fc01803

…the way, as it hangs" This reverts commit 3319deb.

mshinwell force-pushed the runtime5-features branch from a56431c to fc01803 Compare November 16, 2023 15:19

mshinwell added 2 commits November 16, 2023 15:47

Fix tests/gc-roots

3afaca4

Fix tests/asmcomp/polling.c

18aca88

mshinwell mentioned this pull request Nov 16, 2023

(dynlink) port #753 #784 #2041

Merged

mshinwell and others added 2 commits November 16, 2023 16:09

Move tool-debugger out of the way again

72538a4

port oxcaml#753 and oxcaml#784

547550a

(cherry picked from commit 5fd93fe)

mshinwell added 2 commits November 16, 2023 17:17

Fixing of backtrace tests

4c9aa19

Add runtime5 predicate in ocamltest and use it to fix backtrace_c_exn.ml

c716821

mshinwell added 2 commits November 16, 2023 17:33

Skip instrumented-runtime tests on 5.x

d5f8d91

Fix dynlink for bytecode

5c33c7d

mshinwell added 4 commits November 16, 2023 18:42

Fixing of native dynlink

e9d4dd3

Initial version of fix for dynlink duplicate root registration

ab2cbc8

Revert "Move tool-debugger out of the way again"

d9df07a

This reverts commit 72538a4.

Fix Ctype.unify call in debugger/loadprinter.ml

4f56483

mshinwell added 11 commits November 17, 2023 10:28

Move Condition, Mutex and Semaphore to the stdlib - fixes for runtime4/

7b02fbc

Fixing dynlink for runtime4/

81bac2e

Fix get_header.ml test

308c23a

Forgotten files from lib-obj fixing commit

50fb138

Fix backtrace_c_exn tests for runtime4

49e8613

Dynlink / Mutex etc fixing continued

af9169d

Fix runtime-naked-pointers tests

4baa673

Fix mistake in ocaml/runtime4/dynlink.c

0da41f8

Fix wrong position of modules line in ocaml/testsuite/tests/typing-lo…

039e6ae

…cal/regions.ml test header

Promote tests

599fe9c

Fix bug in caml_gc_counters in the 5 runtime

b76b8bd

mshinwell merged commit b76b8bd into oxcaml:runtime5-features Nov 17, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Making the testsuite pass with runtime5#2034

Making the testsuite pass with runtime5#2034
mshinwell merged 50 commits intooxcaml:runtime5-featuresfrom
mshinwell:runtime5-features

mshinwell commented Nov 15, 2023

Uh oh!

TheNumbat commented Nov 15, 2023

Uh oh!

mshinwell commented Nov 16, 2023

Uh oh!

mshinwell commented Nov 16, 2023

Uh oh!

mshinwell commented Nov 16, 2023

Uh oh!

mshinwell commented Nov 16, 2023

Uh oh!

mshinwell commented Nov 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

mshinwell commented Nov 15, 2023

Uh oh!

TheNumbat commented Nov 15, 2023

Uh oh!

mshinwell commented Nov 16, 2023

Uh oh!

mshinwell commented Nov 16, 2023

Uh oh!

mshinwell commented Nov 16, 2023

Uh oh!

mshinwell commented Nov 16, 2023

Uh oh!

mshinwell commented Nov 17, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants