Middle and backend support for unboxed float/int32/int64/nativeint arrays#1926
Closed
mshinwell wants to merge 2 commits intooxcaml:mainfrom
Closed
Middle and backend support for unboxed float/int32/int64/nativeint arrays#1926mshinwell wants to merge 2 commits intooxcaml:mainfrom
mshinwell wants to merge 2 commits intooxcaml:mainfrom
Conversation
goldfirere
approved these changes
Oct 12, 2023
Collaborator
goldfirere
left a comment
There was a problem hiding this comment.
Only file owned by me.
0e6a9c8 to
3e8fc6b
Compare
Collaborator
Author
|
This has been updated and now uses custom blocks to represent the arrays. The unboxed |
3e8fc6b to
2b127b6
Compare
Collaborator
|
Who is going to review this? @mshinwell and I discussed yesterday that 1) there is no way to test the new codepaths in this PR and 2) we should merge anyway. Tests will come when we add frontend support. But first some review would be good, I think. |
Collaborator
Author
|
@Gbury is reviewing |
Gbury
requested changes
Oct 19, 2023
Contributor
|
Closing this one since it is superseded by #2185 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the arrays of the following element layouts to
Lambdaarray kinds:floatint32int64nativeintIt then threads this through the middle end and backend. It should support all the usual things e.g. static allocation. There are still two things missing [update: now both fixed - see below]:
Abstract_taginstead ofCustom_tagjust for the moment.There are some places in flambda2 where we could probably now factor out some code.