Closed
Conversation
The following tests - tests/lib-systhreads/eintr.ml and tests/async-exns/async_exns_1 were failing. This patch loads the trap ptr into Caml_state->async_exception_pointer in arm64.S which fixes the test cases.
This patch implements local allocation by adding code emission for local allocation, regions and assembly routine for calling stack relocation.
The tests/backend/regalloc_validator test was failing because register names were hard-coded for amd64. Created a new test with arm64 names to fix this and modified the dune file to enable the respective tests on each platform.
Contributor
|
Thanks for the pull request! About note 1, I will have a closer |
Contributor
Author
|
Of course, please take your time. |
TheNumbat
reviewed
Aug 8, 2023
Partially reverts commit 4a29540. The previous commit disabled the test on arm64 in the upstream testsuite, which was not necessary.
Syncs the backend/arm64/emit.mlp changes with upstream asmcomp/arm64/emit.mlp for local allocation. This was missed in a previous commit.
This was referenced Apr 15, 2024
Collaborator
|
@anmolsahoo25 could you please confirm here that you agree to the contents of the Developer Certificate of Origin (https://developercertificate.org/)? |
Contributor
Author
|
I have read and agree to the contents of https://developercertificate.org/. |
Collaborator
|
@anmolsahoo25 thanks |
Contributor
Author
|
@mshinwell Thank you too, for taking a look at the code and bringing it up to par for merging. |
Collaborator
|
Thanks for the submission - this is good work. We should have the remainder merged via the other PRs in not too long. |
Contributor
Author
|
Looking forward to it. :) |
Collaborator
|
This has all been merged via other PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR proposes patches that enable the main branch to be compiled and tested on arm64 machines.
Summary of changes -
Notes -
-msse4.2flag causes compilation errors for the stubs.Apologies if I am not adhering to general PR guidelines. It's my first PR and I am open to feedback!