zero_alloc: always compute summaries#1335
Merged
gretay-js merged 1 commit intooxcaml:mainfrom May 3, 2023
Merged
Conversation
Always compute sumaries.
92a8f9e to
8b4ad2a
Compare
Contributor
Author
|
Testing this PR on a large build with flambda1:
|
xclerc
approved these changes
May 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Always run
Checkmachanalysis to compute sumaries needed for checkingzero_allocassertions and store the summaries in cmx files.Use
Clflags.zero_alloc_checkfor assertion checking only, not for computing summaries. Currently,-zero-alloc-flagflag does both. This PR proposes to change the meaning of-zero-alloc-checkbecause the overhead of always having summaries is low (to be confirmed on a large build). Having summaries makes it easy to turn the check on for a particular file or library, because there is no need to rebuild its dependencies.