Add --enable-dev configure option + use -O3 for the compiler#1291
Open
mshinwell wants to merge 2 commits intooxcaml:mainfrom
Open
Add --enable-dev configure option + use -O3 for the compiler#1291mshinwell wants to merge 2 commits intooxcaml:mainfrom
mshinwell wants to merge 2 commits intooxcaml:mainfrom
Conversation
rleshchinskiy
requested changes
Apr 6, 2023
Contributor
rleshchinskiy
left a comment
There was a problem hiding this comment.
It would be good to recommend --enable-dev in README.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a new
configureoption called--enable-dev. The idea is that this should be specified for normal development. It builds everything with-opaque, which should be faster, together with warnings-as-errors (for both OCaml and C code). Furthermoreocamltestwill be built.When not specifying
--enable-dev, this now uses-O3to build the compiler itself (for the dune builds). Currently it seems that e.g. Closure is faster in the typechecker than Flambda 2, probably because the default optimization level for the latter is a strange intermediate state that isn't classic mode, but is lower than-O2(we should fix this separately). This change should hopefully close that gap.