Merged
Conversation
mshinwell
requested changes
Mar 24, 2023
Contributor
Author
|
@mshinwell comments have been addressed, this is ready for another review |
mshinwell
approved these changes
Mar 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a debug option for flambda2. This option can be used either via a CLI flag
-flamdba2-debugor via en env variableFLAMBDA2_DEBUG.Currently, setting this to
trueonly gives unique names to every continuation, which makes it a lot easier to follow what happens to which continuation.Additionally,
Simplify_importnow defines thedebug ()function, that can be used in code to add debugging statements such asif debug () then Format.eprintf ...., which happens quite a lot in my experience.