flambda-backend: Zero alloc fix assume payload parsing (#2152)

gretay-js · web-flow · commit b74ea89acb30 · 2023-12-14T13:04:13.000Z
Fix a bug in payload detection for [@zero_alloc assume ..]

Correctly detect the following
[@zero_alloc assume never_returns_normally strict]

payload keywords passed to [parse_ids_payload] must be sorted
alphabetically.
diff --git a/lambda/translattribute.ml b/lambda/translattribute.ml
@@ -136,6 +136,8 @@ let get_ids_from_exp exp =
   |> Result.map List.rev
 
 
+(* [parse_ids_payload] requires that each element in [cases]
+   the first component (string list) is alphabetically sorted. *)
 let parse_ids_payload txt loc ~default ~empty cases payload =
   let[@local] warn () =
     let ( %> ) f g x = g (f x) in
@@ -270,7 +272,7 @@ let parse_property_attribute attr property =
           Assume { property; strict = true; never_returns_normally = false; loc; };
           ["assume"; "never_returns_normally"],
           Assume { property; strict = false; never_returns_normally = true; loc; };
-          ["assume"; "strict"; "never_returns_normally"],
+          ["assume"; "never_returns_normally"; "strict";],
           Assume { property; strict = true; never_returns_normally = true; loc; };
           ["ignore"], Ignore_assert_all property
         ]
