Skip to content

Revert "Remove unnecessary parentheses around expressions with trailing [@attrs]"#7

Merged
ccasin merged 1 commit intojanefrom
revert-6-attr-paren-placement
Aug 17, 2022
Merged

Revert "Remove unnecessary parentheses around expressions with trailing [@attrs]"#7
ccasin merged 1 commit intojanefrom
revert-6-attr-paren-placement

Conversation

@ccasin
Copy link
Copy Markdown

@ccasin ccasin commented Aug 17, 2022

Reverts #6. This PR should, possibly, be made upstream instead.

@ccasin
Revert "Remove unnecessary parentheses around expressions with traili…
33dd0c3 
…ng [@attrs] (#6)"

This reverts commit fa97085.

Signed-off-by: Chris Casinghino <ccasinghino@janestreet.com>
@ccasin ccasin force-pushed the revert-6-attr-paren-placement branch from cc09c6a to 33dd0c3 Compare August 17, 2022 22:08
@ccasin ccasin merged commit b5c8db0 into jane Aug 17, 2022
@lpw25
Copy link
Copy Markdown

lpw25 commented Aug 20, 2022

What if we only do this transformation for [@tail] and [@nontail] specifically?

@ccasin
Copy link
Copy Markdown
Author

ccasin commented Sep 19, 2022

After discussion with Carl we've decided this is fine as long as we upstream it in parallel. I've force pushed to restore the jane branch to before this PR was applied (so #6 was never reverted).

@ccasin ccasin deleted the revert-6-attr-paren-placement branch September 19, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ccasin @lpw25