Don't desugar let _ = local_ x#20
Closed
Julow wants to merge 3 commits intooxcaml:rebase-js-extensions-on-upstreamfrom
Closed
Don't desugar let _ = local_ x#20Julow wants to merge 3 commits intooxcaml:rebase-js-extensions-on-upstreamfrom
let _ = local_ x#20Julow wants to merge 3 commits intooxcaml:rebase-js-extensions-on-upstreamfrom
Conversation
Signed-off-by: Chris Casinghino <ccasinghino@janestreet.com>
Signed-off-by: Chris Casinghino <ccasinghino@janestreet.com>
The desugared syntax `let local_ _ = x` is invalid. Signed-off-by: Jules Aguillon <jules@j3s.fr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desugared syntax
let local_ _ = xis invalid.This is currently based on the branch that contains our changes:
rebase-js-extensions-on-upstream. Happy to rebase this on top of an other branch.