Layouts (stage 4): print layouts of type variables in a comment when the user asks twice#32
Merged
ncik-roberts merged 15 commits intomainfrom Dec 12, 2023
Merged
Layouts (stage 4): print layouts of type variables in a comment when the user asks twice#32ncik-roberts merged 15 commits intomainfrom
ncik-roberts merged 15 commits intomainfrom
Conversation
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
5deae29 to
d3f9ceb
Compare
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
d3f9ceb to
bbb6dda
Compare
ac483be to
d928e85
Compare
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
alanechang
approved these changes
Dec 11, 2023
alanechang
left a comment
There was a problem hiding this comment.
Looks good overall! Left some comments related to implementation details.
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
Signed-off-by: Nick Roberts <nroberts@janestreet.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed internally. When the user queries a type expression twice, we print
(* 'a_1 : layout_1, ..., 'a_n : layout_n *)for all type variables'a_iwith non-boring layoutlayout_i.Note: type variables are printed in the reverse order from what you'd expect. This is a general issue with type printing in flambda-backend; I'll post a PR there rather than fixing it in this PR.