fix(justfile): use --ignore-workspace for e2e pnpm commands#983
Merged
camc314 merged 2 commits intoJun 3, 2026
Conversation
The root pnpm-workspace.yaml causes pnpm invoked from e2e/ to resolve the parent workspace and skip installing e2e's own deps, leaving vitest missing after `just init`. CI already works around this with `pnpm --ignore-workspace`; apply the same flag in the justfile so local `just init` and `just test` work out of the box.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#968 added PNPM workspace configuration and updated CI commands to use
--ignore-workspace. The justfile still runs pnpm commands as before, causing pnpm to ignore the nestede2epackage since it's not listed in the workspace. Because of thatjust testfails due to missingviteston a fresh clone.