perf: Concurrent tsconfig lookup per file#555
Conversation
1ff598f to
b7ba81a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Testing with aws/aws-cdk revealed failure to resolve tsconfig. Keeping this PR in draft status until the issue is resolved. |
is that a regression? |
|
EDIT: The "bug" was CLI misconfiguration. I should have used @camc314
I will debug the details tomorrow and create an issue for it. # Setup
git clone -depth=1 git@github.com:aws/aws-cdk.git
# Bad
pnpm dlx oxlint -A all -D typescript/no-floating-promises --type-aware /Users/noyan/ghq/github.com/aws/aws-cdk
# shows `typescript(tsconfig-error): Invalid tsconfig`
# `Found 0 warnings and 13 errors. `
# Good
pnpm dlx oxlint -A all -D typescript/no-floating-promises --type-aware ~/ghq/github.com/aws/aws-cdk
# shows `Found 0 warnings and 542 errors.` |
|
perfect, if you can address this comment this should be good to merge. Thanks for your work on this! |
|
@camc314 |
|
forgot to merge this 🫣 |
|
This is something specific to tsgolint, and not something that can be upstreamed, right? |
yeah specific to tsgolint |
This PR optimizes
tsconfigresolution by 75% by improving concurrency , resulting in ~75% faster resolution in large projects.This removes a major bottleneck in large codebases; Kibana now completes resolution in ~3 seconds.
fix #554
Benchmark (vs. main branch)
This PR is 40% faster than main at elastic/kibana (excluding node_modules).
Details
Note
Disclosure: I used some AI tools: Claude Code for prototype and writing tests, Gemini and ChatGPT for reviewing my code and improve my English.