Skip to content

fix: escape file and sourceRoot fields#294

Merged
Boshen merged 1 commit into
mainfrom
fix/escape-file-and-source-root-fields
Mar 24, 2026
Merged

fix: escape file and sourceRoot fields#294
Boshen merged 1 commit into
mainfrom
fix/escape-file-and-source-root-fields

Conversation

@sapphi-red

Copy link
Copy Markdown
Member

file and sourceRoot fields can contain arbitrary character but was not escaping the character properly.

@codspeed-hq

codspeed-hq Bot commented Mar 24, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 2.43%

⚡ 2 improved benchmarks
❌ 3 regressed benchmarks
✅ 8 untouched benchmarks
⏩ 5 skipped benchmarks1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
serialize[real_small] 4.4 µs 4.3 µs +2.77%
serialize[real_medium] 5 µs 4.9 µs +2.45%
parse[real_small] 12.9 µs 13.2 µs -2.43%
from_json_string_inline 15.4 µs 15.8 µs -2.22%
parse[real_medium] 16.1 µs 16.4 µs -1.95%

Comparing fix/escape-file-and-source-root-fields (ad0191c) with main (2ee7fe0)

Open in CodSpeed

Footnotes

  1. 5 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@sapphi-red sapphi-red requested a review from Boshen March 24, 2026 07:50
@Boshen Boshen merged commit 0eb8957 into main Mar 24, 2026
7 checks passed
@Boshen Boshen deleted the fix/escape-file-and-source-root-fields branch March 24, 2026 10:14
@Boshen Boshen mentioned this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants