Skip to content

feat(cli): use insta_cmd for cli snapshot testing#791

Merged
Boshen merged 1 commit intomainfrom
insta_cmd
Aug 25, 2023
Merged

feat(cli): use insta_cmd for cli snapshot testing#791
Boshen merged 1 commit intomainfrom
insta_cmd

Conversation

@Boshen
Copy link
Copy Markdown
Member

@Boshen Boshen commented Aug 25, 2023

closes #776

@github-actions github-actions Bot added the A-linter Area - Linter label Aug 25, 2023
@Boshen Boshen force-pushed the insta_cmd branch 3 times, most recently from 7874248 to 525d225 Compare August 25, 2023 07:44
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Aug 25, 2023 •
edited
Loading

Benchmark Results

Linux

group                            main                                   pr
-----                            ----                                   --
minifier/antd.js                 1.00    287.4±2.99ms    22.2 MB/sec    1.00    287.9±3.62ms    22.2 MB/sec
minifier/react.development.js    1.00      3.1±0.01ms    22.0 MB/sec    1.00      3.1±0.01ms    22.1 MB/sec
minifier/typescript.js           1.01   489.8±13.92ms    21.1 MB/sec    1.00   482.7±12.86ms    21.4 MB/sec
minifier/vue.js                  1.00     19.5±0.41ms    16.8 MB/sec    1.03     20.0±0.43ms    16.3 MB/sec
parser/antd.js                   1.00     94.0±0.76ms    67.8 MB/sec    1.01     94.8±1.42ms    67.3 MB/sec
parser/react.development.js      1.01  1060.9±38.93µs    64.8 MB/sec    1.00  1051.9±21.53µs    65.4 MB/sec
parser/typescript.js             1.00    160.1±0.60ms    64.4 MB/sec    1.00    160.2±1.18ms    64.4 MB/sec
parser/vue.js                    1.00      6.6±0.10ms    49.8 MB/sec    1.00      6.6±0.01ms    49.8 MB/sec
semantic/antd.js                 1.03     92.1±4.07ms    69.3 MB/sec    1.00     89.5±4.98ms    71.3 MB/sec
semantic/react.development.js    1.00   989.3±20.17µs    69.5 MB/sec    1.00   992.1±88.67µs    69.3 MB/sec
semantic/typescript.js           1.03    198.7±8.98ms    51.9 MB/sec    1.00    193.6±9.09ms    53.3 MB/sec
semantic/vue.js                  1.01      6.9±0.22ms    47.6 MB/sec    1.00      6.8±0.21ms    48.0 MB/sec

Windows

group                            main                                   pr
-----                            ----                                   --
minifier/antd.js                 1.03   350.4±14.46ms    18.2 MB/sec    1.00   339.1±11.54ms    18.8 MB/sec
minifier/react.development.js    1.03      3.5±0.21ms    19.7 MB/sec    1.00      3.4±0.05ms    20.4 MB/sec
minifier/typescript.js           1.01   523.9±16.82ms    19.7 MB/sec    1.00   520.5±17.15ms    19.8 MB/sec
minifier/vue.js                  1.00     21.8±0.90ms    15.0 MB/sec    1.01     22.1±1.49ms    14.8 MB/sec
parser/antd.js                   1.02     94.7±5.76ms    67.4 MB/sec    1.00     92.7±4.33ms    68.8 MB/sec
parser/react.development.js      1.00   999.3±29.02µs    68.8 MB/sec    1.00  1003.9±48.08µs    68.5 MB/sec
parser/typescript.js             1.01    156.9±4.58ms    65.8 MB/sec    1.00    155.4±5.72ms    66.4 MB/sec
parser/vue.js                    1.00      6.3±0.28ms    51.6 MB/sec    1.00      6.3±0.25ms    51.8 MB/sec
semantic/antd.js                 1.04   109.0±11.17ms    58.5 MB/sec    1.00    105.2±9.34ms    60.6 MB/sec
semantic/react.development.js    1.04  1140.3±84.27µs    60.3 MB/sec    1.00  1092.8±54.33µs    63.0 MB/sec
semantic/typescript.js           1.03   237.8±19.05ms    43.4 MB/sec    1.00   230.6±19.13ms    44.7 MB/sec
semantic/vue.js                  1.00      7.9±0.46ms    41.5 MB/sec    1.07      8.4±0.67ms    38.9 MB/sec

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1c6b87b) 92.54% compared to head (525d225) 92.54%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #791   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files         203      203           
  Lines       41811    41827   +16     
=======================================
+ Hits        38693    38709   +16     
  Misses       3118     3118
Files Changed Coverage Δ
crates/oxc_cli/src/command.rs 89.74% <100.00%> (+1.01%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Boshen Boshen merged commit 5921375 into main Aug 25, 2023
@Boshen Boshen deleted the insta_cmd branch August 25, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

A-linter Area - Linter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat(cli): test cli commands with assert_cmd or insta_cmd

2 participants

@Boshen @codecov-commenter