fix(linter/no-negated-condition): add autofix for negated if/ternary#23803
Closed
JonasBa wants to merge 2 commits into
Closed
fix(linter/no-negated-condition): add autofix for negated if/ternary#23803JonasBa wants to merge 2 commits into
JonasBa wants to merge 2 commits into
Conversation
added 2 commits
June 25, 2026 20:51
Make eslint and unicorn `no-negated-condition` fixable by inverting the test (`!` removal or `!=`/`!==` → `==`/`===`) and swapping branches, including brace wrapping for non-block if arms and ASI / return-throw edge cases aligned with eslint-plugin-unicorn.
Collapse duplicate swap helpers, inline ternary edge-case handling, and trim comments so the invert-test + swap-arms flow is easier to follow.
a141268 to
c9e25b1
Compare
2 tasks
Contributor
|
Thanks for working on this! This got fixed via #23825 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
eslint/no-negated-conditionandunicorn/no-negated-conditionfixable via shared logic inrules/shared/eslint_unicorn/no_negated_condition.rs.!removal, or!=/!==→==/===) and swaps consequent/alternate branches.ifarms (brace wrap), ASI when removing a leading!,return/throwspacing and multi-line paren wrapping, and fixing only the innerelse ifinif / else if / elsechains.!only rewrite the operator (e.g.!a !== b→!a === b), matching eslint-plugin-unicorn.AI usage: This PR was developed with AI assistance. I reviewed the logic, tests, and unicorn snapshot parity (with one intentional whitespace delta on multi-line
return ! // commentfixes: one space after(vs unicorn’s two).Test plan
cargo test -p oxc_linter --lib no_negated_condition--fixon a few negatedif/? :samples if useful