fix(linter): avoid consistent-test-it describe leakage#22632
Closed
ipanasenko wants to merge 4 commits into
Closed
fix(linter): avoid consistent-test-it describe leakage#22632ipanasenko wants to merge 4 commits into
ipanasenko wants to merge 4 commits into
Conversation
ipanasenko
commented
May 20, 2026
Signed-off-by: Illia Panasenko <hottdogg2008@gmail.com>
Signed-off-by: Illia Panasenko <hottdogg2008@gmail.com>
Merging this PR will not alter performance
Comparing 
Footnotes
|
camc314
reviewed
May 21, 2026
Comment on lines
+131
to
+147
| let describe_call_ids = possible_jest_nodes | ||
| .iter() | ||
| .filter_map(|possible_jest_node| { | ||
| let node = possible_jest_node.node; | ||
| let AstKind::CallExpression(call_expr) = node.kind() else { | ||
| return None; | ||
| }; | ||
| let Some(ParsedJestFnCallNew::GeneralJest(jest_fn_call)) = | ||
| parse_jest_fn_call(call_expr, possible_jest_node, ctx) | ||
| else { | ||
| return None; | ||
| }; | ||
|
|
||
| matches!(jest_fn_call.kind, JestFnKind::General(JestGeneralFnKind::Describe)) | ||
| .then_some(node.id()) | ||
| }) | ||
| .collect::<FxHashSet<_>>(); |
Contributor
There was a problem hiding this comment.
hmm i'm a little worried about the perf overhead of this check.
I'll look at this more tomorow
Author
There was a problem hiding this comment.
I know zero Rust, this was written by gpt-5.5, just fyi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22633
Summary
describecall ancestors forconsistent-test-itinstead of leaking state after anydescribecalljestandvitestregression coverage for top-leveltestcalls afterdescribe