Skip to content

refactor(linter): use is_interactive_role for no_noninteractive_tabindex#21987

Merged
camc314 merged 2 commits intooxc-project:mainfrom
mehm8128:refactor/use-is_interactive_role-method
May 2, 2026
Merged

refactor(linter): use is_interactive_role for no_noninteractive_tabindex#21987
camc314 merged 2 commits intooxc-project:mainfrom
mehm8128:refactor/use-is_interactive_role-method

Conversation

@mehm8128
Copy link
Copy Markdown
Contributor

@mehm8128 mehm8128 commented Apr 30, 2026

@mehm8128 mehm8128 requested a review from camc314 as a code owner April 30, 2026 13:21
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 30, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 4 untouched benchmarks
⏩ 47 skipped benchmarks1

Comparing mehm8128:refactor/use-is_interactive_role-method (ac647b1) with main (75fc551)2

Open in CodSpeed

Footnotes

  1. 47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on main (5699d53) during the generation of this report, so 75fc551 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@camc314 camc314 added the A-linter Area - Linter label May 1, 2026
@mehm8128 mehm8128 changed the title refactor: use is_interactive_role for no_noninteractive_tabindex refactor(linter): use is_interactive_role for no_noninteractive_tabindex May 1, 2026
mehm8128
mehm8128 commented May 2, 2026
View reviewed changes
Comment thread crates/oxc_linter/src/rules/jsx_a11y/no_noninteractive_tabindex.rs
camc314
camc314 approved these changes May 2, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@camc314 camc314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@camc314 camc314 merged commit 26aded4 into oxc-project:main May 2, 2026
26 checks passed
@camc314 camc314 self-assigned this May 2, 2026
@Dunqing Dunqing mentioned this pull request May 7, 2026
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@camc314 camc314 camc314 approved these changes

Assignees

@camc314 camc314

Labels

A-linter Area - Linter

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mehm8128 @camc314